Skip to content

AOT Unit Tests: Cache NgSummaries loaded in a test #19817

Closed

Description

@vikerman

We want to make the NgSummary used in a test configurable at a spec level. This would mean that we would end up processing the transitive NgSummary tree per test - which would be too slow.

We should cache all known NgSummary functions with the child tree as the cached value - So that we don't have to walk this tree for every test.

Activity

  1. added
    area: coreIssues related to the framework runtime
    area: testingIssues related to Angular testing features, such as TestBed
    on Oct 20, 2017
  2. removed their assignment
    on Oct 26, 2017
  3. tbosch commented on Oct 27, 2017

    @tbosch
    Contributor

    Cache in the CompilerFactory and add an argument ngSummaries to configureTestingModule. This way, the cache is not top level, but only lives between calls to initTestEnvironment and resetTestEnvironment (which should be called only 1x).

  4. added a commit that references this issue on Oct 28, 2017
    272c27b
  5. assigned
    and
    vicb
    and unassigned on Oct 28, 2017
  6. tbosch commented on Nov 1, 2017

    @tbosch
    Contributor

    See my PR #19996 which @vicb is taking over.

  7. added
    featureLabel used to distinguish feature request from other issues
    on Nov 6, 2017
  8. angular-automatic-lock-bot commented on Sep 12, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: coreIssues related to the framework runtimearea: testingIssues related to Angular testing features, such as TestBedfeatureLabel used to distinguish feature request from other issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions