Skip to content

docs(tutorial) - toh-pt2 could be more clear in the "Expose heroes" section #19714

New issue
New issue
Closed
Closed
docs(tutorial) - toh-pt2 could be more clear in the "Expose heroes" section#19714
Assignees
sreevani-ship-it
Labels
featureLabel used to distinguish feature request from other issuesfreq3: highstate: communitySomeone from the Angular community is working on this issue or submitted this PRstate: has PR
Milestone
Backlog

Description

@dogeared
dogeared
opened on Oct 13, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

For n00bs, in part 2 of the tutorial, it is not clear where the heroes = HEROES; line should go exactly.

What is the motivation / use case for changing the behavior?

To make it easier for newcomers to angular to follow the tutorial

Environment


Angular version: 4.4.5


Browser:
all

Activity

  1. trotyl commented on Oct 14, 2017

    @trotyl
    trotyl
    on Oct 14, 2017
    Contributor

    The order of properties does not matter at all in any kind of class, why should it be "cleared" if it's not a requirement?

    Order of class members is just a favor of code style (there're indeed tslint rule for it), but following a tutorial does not mean you need to use the exact same format as the example did, you can use spaces or tabs, single quote or double quote, with or without semicolon according to personal preference.

  2. dogeared commented on Oct 14, 2017

    @dogeared
    dogeared
    on Oct 14, 2017 via email
    Author

  3. trotyl commented on Oct 15, 2017

    @trotyl
    trotyl
    on Oct 15, 2017
    Contributor

    Create a public property ...

    Angular tutorial assume that you already have JavaScript background, this is not a JavaScript tutorial.

  4. dogeared commented on Oct 15, 2017

    @dogeared
    dogeared
    on Oct 15, 2017 via email
    Author

  5. kapunahelewong commented on Oct 16, 2017

    @kapunahelewong
    kapunahelewong
    on Oct 16, 2017
    Contributor

    Hey @dogeared thanks for bringing this up. I agree – clarifying this can only help improve the learning experience. I'll make sure to pass this along to the right person on the docs team.

  6. dogeared commented on Oct 16, 2017

    @dogeared
    dogeared
    on Oct 16, 2017 via email
    Author

  7. kapunahelewong commented on Oct 16, 2017

    @kapunahelewong
    kapunahelewong
    on Oct 16, 2017
    Contributor

    Yeah, I know exactly what you mean. Feel free to add any more you notice here or in your PR and to tag me when you do. I've stumbled over some like that and try to fix them when I see them, but haven't done a whole sweep. The more eyes, the better. Thanks again for catching that.

  8. tbosch commented on Oct 16, 2017

    @tbosch
    tbosch
    on Oct 16, 2017
    Contributor

    Would be nice if somebody put a PR together.

  9. dogeared commented on Oct 16, 2017

    @dogeared
    dogeared
    on Oct 16, 2017 via email
    Author
  10. tbosch
    added
    comp: docs
    on Oct 17, 2017
  11. kapunahelewong
    added
    effort1: hours
    freq2: medium
    severity1: confusing
    on Jan 4, 2018
  12. ngbot
    added this to the needsTriage milestone on Feb 26, 2018
  13. jenniferfell
    added
    featureLabel used to distinguish feature request from other issues
    on May 25, 2018

  14. 1 remaining item

  15. jenniferfell
    added
    severity2: inconvenient
    state: has PR
    subtype: docs-clarification
    and removed
    effort1: hours
    freq2: medium
    severity1: confusing
    on May 25, 2018
  16. ngbot
    modified the milestones: needsTriage, Backlog on May 25, 2018
  17. jenniferfell
    added
    state: communitySomeone from the Angular community is working on this issue or submitted this PR
    on May 25, 2018
  18. jenniferfell
    added
    docsarea: tutorial
    on Jun 6, 2018
  19. jenniferfell
    assigned
    sreevani-ship-it
    on Jun 15, 2018

  20. sreevani-ship-it commented on Jun 17, 2018

    @sreevani-ship-it
    sreevani-ship-it
    on Jun 17, 2018
    Contributor

    PR #19715

  21. sreevani-ship-it
    closed this as completedon Oct 9, 2018

  22. angular-automatic-lock-bot commented on Sep 14, 2019

    @angular-automatic-lock-bot
    angular-automatic-lock-botBot
    on Sep 14, 2019

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  23. angular-automatic-lock-bot
    locked and limited conversation to collaborators on Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featureLabel used to distinguish feature request from other issuesfreq3: highstate: communitySomeone from the Angular community is working on this issue or submitted this PRstate: has PR

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions