Repository navigation
AOT Compilation starting documentation: missing npm scripts #18544
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
In this section, npm script is missing after this line:
Extend the scripts section of the package.json with these npm scripts:
However, these missing npm scripts are not missing in package.json. Could we remove this line in case of confusion?
Expected behavior
Following scripts should be added under that line:
"build:aot": "ngc -p tsconfig-aot.json && rollup -c rollup-config.js",
"serve:aot": "lite-server -c bs-config.aot.json",
Activity
fix(aio): add missing code snippet
fix(aio): add missing code snippet (#18547)
fix(aio): add missing code snippet (#18547)
pwwpche commentedon Aug 9, 2017
Should we also remove this line from that doc?
Extend the scripts section of the package.json with these npm scripts:gkalpak commentedon Aug 9, 2017
@pwwpche, why remove that line?
pwwpche commentedon Aug 9, 2017
I didn't notice any npm scripts that should be extended into package.json. So I'm not quite sure what scripts that this line is referring to.
Possibly these scripts are already there so we no longer need to manually add them to package.json?
gkalpak commentedon Aug 10, 2017
Have you seen https://github.com/angular/angular/pull/18547/files?
Are you saying the scripts are needed or that they are already in package.json?
pwwpche commentedon Aug 10, 2017
They are already in package.json, so I guess this is why the script is removed from the doc.
There is another missing script in that same page.
Use the same lite-server employed elsewhere in the documentation:Nowhere else on that page states what is this
lite-serverscript.That's not big deal since it's easy to figure out the lite-server script, but it might be better to also list that on the doc. I don't want to submit another issue for this because it's ok if you're not adding it.
fix(aio): add missing code snippet (angular#18547)
gkalpak commentedon Aug 11, 2017
I see what you mean. Well, it is not exactly clear, because for the most part you use the quickseed boilerplate (which doesn't have the scripts) and then it tells you to download a zip (which does have the scripts). I also realized there was another code-snippet missing.
Submitted #18650 which will hopefully make things more clear (or at least less confusing 😛).
pwwpche commentedon Aug 11, 2017
Awesome! No confusion any more.
Thanks!
fix(aio): add missing code snippet (angular#18547)
fix(aio): add missing code snippet (angular#18547)
angular-automatic-lock-bot commentedon Sep 12, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.