You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: Tour of Heroes: Incomplete code example #18078
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
<a*ngFor="let hero of heroes" [routerLink]="['/detail', hero.id]" class="col-1-4">
The anchor tag is missing its closing </a> that even the copy link in the code doesn't have.
If a user copies this as-is into their project file, they'll get a runtime error about a missing </div> tag.
Minimal reproduction of the problem with instructions
Download the example zip file, remove lines 2-5 from the example above in the dashboard.component.html file and run the app.
What is the motivation / use case for changing the behavior?
Reduce new user confusion in learning Angular.
Environment
Angular version: 4.0.0
Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
Activity
jenniferfell commentedon Jun 4, 2018
specifically, this location: https://angular.io/tutorial/toh-pt5#dashboardcomponent-hero-links
sreevani-ship-it commentedon Oct 8, 2018
Fixed in PR #24445
angular-automatic-lock-bot commentedon Sep 14, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.