Repository navigation
Deprecation in Router Documentation #17905
Description
I'm submitting a ...
[ ] Regression (behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
In the router documentation page, under adding animations,
the code sample should be refactored, since AnimationEntryMetadata is deprecated and the rest have moved to angular/animations.
import { animate, AnimationEntryMetadata, state, style, transition, trigger } from '@angular/core';
export const slideInDownAnimation: AnimationEntryMetadata
Expected behavior
Should read:
import { animate, state, style, transition, trigger } from '@angular/animations';
export const slideInDownAnimation
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Please tell us about your environment
Angular version: X.Y.Z
4.2.5
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: XX
- Platform:
Others:
Reacted by akotynski
Activity
[-]Deprecation in Router [/-][+]Deprecation in Router Documentation[/+]abdel-ships-it commentedon Jul 3, 2017
I think it's safe to just remove
AnimationEntryMetadatafrom the documentation.jasonaden commentedon Jul 18, 2017
@matsko Can you make a suggestion on this one?
brandonroberts commentedon Oct 13, 2017
This should be resolved once #19630 lands
docs(animations): fix up routing doc example to import from @angular/…
jasonaden commentedon Dec 7, 2017
Resolved with #20334
mmatlock-shr commentedon Mar 8, 2018
This is still an issue in current documentation for v5.2.8, #20334 is still an open pull request it looks like?
angular-automatic-lock-bot commentedon Sep 13, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.