App won't start on version 2.4.8

I'm submitting a ... (check one with "x")

[x ] bug report 
[ ] feature request
[ ] support request

Current behavior

After update angular my application shows the loader and that's it, nothing happens.
On version 2.4.7 the site works just fine.
I have no errors on console. I have no clue what's causing this issue except the version change
Expected behavior

The site should work just like it 2.4.7

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Updating angular from 2.4.7 to 2.4.8

Please tell us about your environment:

Windows 10,
Webstorm 2016.3.3

Angular version: 2.0.8

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome 56.0.2924.87 (Only one that was tested)

Language: [all | TypeScript X.X | ES6/7 | ES5]
TypeScript 2.1.6

Pls add a repro

A repro of what ? I can't link to the app cause it's a closed project..

what do you think we can do with it without the info how to reproduce? http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5?p=preview <- app using 2.4.8 and it works fine

I am also having the same issue. One of my nested route has a canLoad guard which is returning false initially and my app component is making a api request and based on that response I redirect the user. It was working fine till 2.4.7 but now app.component is not initializing and hence this api request is not going.

Looks like a bug was introduced in #14327

@ASHFAQPATWARI

but as I said it's very hard to do something without a small repro.
@ASHFAQPATWARI can you provide a plunkr?

can you point me to a plunker with route and route guards? Then I will do the necessary changes in it to reproduce this issue.

I have the same issue with 2.4.8.
It works only after canLoad or Resolve is turned off.

Yes, even if I return true in my canLoad, then things are working.

@ASHFAQPATWARI

@ASHFAQPATWARI http://plnkr.co/edit/JWkl619QHbDiUtgec33t?p=preview

@DzmitryShylovich

@DzmitryShylovich here is the repo to reproduce the issue:
http://plnkr.co/edit/RKMEWDN44rf8yoyYP2Ya?p=preview

There is a service called LoginService, in that make variable isLoggedIn true and code in app.component will initialize else not.

Not sure if it's related, but after updating to *.4.8, I'm getting errors caused by router events happening before root component's constructor is called (where I set up permission rules for my guards). This definitely was not happening in *.4.7.

I too have stumbled upon this issue.. In our case, the following routing structure was causing the error:

const routes: Routes = [
  path: '',
  canActivate: [SomeGuard],
  children: [
      { path: '', redirect: 'some-route', pathMatch: 'full' },
      { path: 'some-route', loadChildren: '......' },
  ]
];

The issue was resolved as soon as I removed lazy loading of the redirect route.

...
{ path: 'some-route, component: SomeRouteComponent }

Obviously, the module that was lazy loaded before needs to be imported into the AppModule.

The original implementation has been working for a long time, and the app stopped loading only after upgrading to 2.4.8

Edit:
Refreshing the page while the user is in any part of the lazy loaded module - doesn't work now as well.. I.e. if the user navigated to any route that was originally lazy loaded, refreshing the page while still being on that route - the app never loads. Guards seem to have no effect in our case.

The issue is gone after downgrading to @angular/router: 3.4.7

@mogusbi

@mogusbi the next release

@DzmitryShylovich

@DzmitryShylovich OK let me rephrase my question then, when can we expect 2.4.9 with this fix to be released? :)

@mogusbi

@mogusbi based on https://github.com/angular/angular/blob/master/docs/RELEASE_SCHEDULE.md I think it would be next week :(, i should have never deleted my node_modules and updated the cli

@juanmcampos

@juanmcampos You don't have to wait the next release, just fix your package.json dependencies to 2.4.7 instead of 2.4.8. (except 3.4.7 for @angular/router)

Example :

"dependencies": {  
  "@angular/common": "2.4.7",  
  "@angular/compiler": "2.4.7",  
  "@angular/core": "2.4.7",  
  "@angular/forms": "2.4.7",  
  "@angular/http": "2.4.7",  
  "@angular/platform-browser": "2.4.7",  
  "@angular/platform-browser-dynamic": "2.4.7",  
  "@angular/platform-server": "2.4.7",  
  "@angular/router": "3.4.7",
  ...
},
"devDependencies": {
  "@angular/compiler-cli": "2.4.7",
  ...
}`

@DzmitryShylovich

@DzmitryShylovich, @vsavkin I see that the sam set of changes causing this issue (41dd62c) have been included on 4.0.0-rc.1 (2a191ca):

router: do not finish bootstrap until all the routes are resolved (#14608) (2a191ca), closes #12162 #14155

Honestly we all had to fall back at 2.4.7 and it seems that won't be able to upgrade to a higher version of 4.0.0-beta.8 because these changes (2a191ca).

The question is, Angular 4.0 is planned to be backwards compatible, or not? Are there any plans about the changes on 2a191ca will exist, or be subject to opt-in, (or whatever) on further releases than rc.1?

Enlightment appreciated

@fulls1z3

@fulls1z3 this change is required for universal #14588 (comment)

The question is, Angular 4.0 is planned to be backwards compatible, or not?

according to semver major releases may contain incompatible changes

revert: fix(router): do not finish bootstrap until all the routes are…

@ritox842

@ritox842 the commit was reverted #14681
so you can close this issue

Ok

@NgModule

This is the best solution 👍
Starting route after APP_Initialize response

@component({})
class App {
constructor(router: Router, loginService: LoginService) {
loginService.initialize();
router.initialNavigation();
}
}

@NgModule({
imports: [
BrowserModule,
RouterModule.forRoot(routes, {initialNavigation: false})
],
declarations: [ App ],
bootstrap: [ App ],
providers: [ Guard, LoginService ]
})
export class AppModule {
}

lock down angular version due to angular/angular#14588

Revert "lock down angular version due to angular/angular#14588"

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Navigation Menu

Repository navigation

App won't start on version 2.4.8 #14588

28 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

App won't start on version 2.4.8 #14588

Description

Activity

DzmitryShylovich commented on Feb 19, 2017

ritox842 commented on Feb 19, 2017

DzmitryShylovich commented on Feb 19, 2017

ASHFAQPATWARI commented on Feb 19, 2017

DzmitryShylovich commented on Feb 19, 2017

DzmitryShylovich commented on Feb 19, 2017

ASHFAQPATWARI commented on Feb 19, 2017

volodymyro-in6k commented on Feb 19, 2017

ASHFAQPATWARI commented on Feb 19, 2017

DzmitryShylovich commented on Feb 19, 2017

ASHFAQPATWARI commented on Feb 19, 2017

fxck commented on Feb 20, 2017

kirjai commented on Feb 20, 2017

28 remaining items

DzmitryShylovich commented on Feb 24, 2017

mogusbi commented on Feb 24, 2017

juanmcampos commented on Feb 25, 2017

JCornat commented on Feb 25, 2017

fulls1z3 commented on Feb 26, 2017

DzmitryShylovich commented on Feb 26, 2017

DzmitryShylovich commented on Feb 28, 2017

ritox842 commented on Feb 28, 2017

pravashupreti commented on Dec 20, 2017

angular-automatic-lock-bot commented on Sep 13, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions