Skip to content

bug(forms): with async validators parent control status is changing wrong #10064

Closed

Description

@nick1247

When using async validation for control and its child controls, parent control status changes if validation of child controls complete although its own validation is pending.

So there is a bag with parent control statuses.
For example, form contains one child control. Child controls validation complete before form validation and child control is valid, form status changes to valid too. Then form validation complete and form status changes to invalid.

plnkr for reproduce

Expected:
Form status changes to valid only if its own validator is in valid state and child controls validators are in valid state

Activity

  1. self-assigned this
    on Oct 12, 2016
  2. kara commented on Oct 12, 2016

    @kara
    Contributor

    @nick1247 Yep, this is a bug. We should be checking whether the group itself is pending when we calculate status, rather than just its descendants.

  3. DzmitryShylovich commented on Dec 11, 2016

    @DzmitryShylovich
    Contributor

    @nick1247 is this still an issue? can u update the plunkr because it doesn't load?

  4. nick1247 commented on Dec 11, 2016

    @nick1247
    Author
  5. added this to the Backlog milestone on Jan 23, 2018
  6. removed this from the Backlog milestone on Feb 20, 2018
  7. added
    open for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).
    on Feb 20, 2018
  8. removed their assignment
    on Feb 20, 2018
  9. benbraou commented on Feb 21, 2018

    @benbraou
    Contributor

    I am going to give this a try (hopefully working on the fix this weekend).

  10. 10 remaining items

  11. added a commit that references this issue on Jun 23, 2020
    a83fcc1
  12. angular-automatic-lock-bot commented on Jul 26, 2020

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  13. locked and limited conversation to collaborators on Jul 26, 2020
  14. added a commit that references this issue on Sep 5, 2020
    d6b730f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions