Skip to content

Commit cd95db4

Browse files
gkalpakalxhub
gkalpak
authored and
alxhub
committed
ci(docs-infra): temporarily lower the min required PWA score for localhost tests (#29911)
The PWA score tests have been occasionally failing on CI recently (possibly due to CI VM/network issues). This commit temporarily disables them, until we investigate the root-cause and/or put a work-around in place. The PWA score tests are still run against the deployed versions (which don't suffer as much) or PRs with public previews (as part of the `test_aio_preview` job) and on upstream builds (as part of the `deploy_aio` job). Related to #29910. [1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390 PR Close #29911
1 parent e5cbc9b commit cd95db4

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎.circleci/config.yml‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,10 @@ jobs:
220220
- run: yarn --cwd aio lint
221221
# Run PWA-score tests
222222
# (Run before unit and e2e tests, which destroy the `dist/` directory.)
223-
- run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
223+
# Temporarily lowering the min required PWA score to avoid flakes on CI.
224+
# TODO(gkalpak): Re-enable once https://github.com/angular/angular/issues/29910 is resolved.
225+
# - run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
226+
- run: yarn --cwd aio test-pwa-score-localhost 70
224227
# Check the bundle sizes.
225228
# (Run before unit and e2e tests, which destroy the `dist/` directory.)
226229
- run: yarn --cwd aio payload-size
@@ -255,7 +258,10 @@ jobs:
255258
- run: yarn --cwd aio build-local --progress=false
256259
# Run PWA-score tests
257260
# (Run before unit and e2e tests, which destroy the `dist/` directory.)
258-
- run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
261+
# Temporarily lowering the min required PWA score to avoid flakes on CI.
262+
# TODO(gkalpak): Re-enable once https://github.com/angular/angular/issues/29910 is resolved.
263+
# - run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
264+
- run: yarn --cwd aio test-pwa-score-localhost 70
259265
# Run unit tests
260266
- run: yarn --cwd aio test --progress=false --watch=false
261267
# Run e2e tests

0 commit comments

Comments
 (0)