refactor(common): improve image directive typings

SkyZeroZx · SkyZeroZx · commit a575a3d5c364 · 2026-01-30T15:02:01.000-05:00
Add image directive typings to improve type safety and removes an unused parameter from the observer registration.
diff --git a/goldens/public-api/common/index.api.md b/goldens/public-api/common/index.api.md
@@ -638,7 +638,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
     static ngAcceptInputType_priority: unknown;
     // (undocumented)
     static ngAcceptInputType_width: unknown;
-    ngOnChanges(changes: SimpleChanges): void;
+    ngOnChanges(changes: SimpleChanges<NgOptimizedImage>): void;
     ngOnInit(): void;
     ngSrc: string;
     ngSrcset: string;
diff --git a/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts b/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts
@@ -92,7 +92,7 @@ export class LCPImageObserver implements OnDestroy {
     return observer;
   }
 
-  registerImage(rewrittenSrc: string, originalNgSrc: string, isPriority: boolean) {
+  registerImage(rewrittenSrc: string, isPriority: boolean) {
     if (!this.observer) return;
     const newObservedImageState: ObservedImageState = {
       priority: isPriority,
diff --git a/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts b/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
@@ -283,7 +283,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
   /**
    * Calculate the rewritten `src` once and store it.
    * This is needed to avoid repetitive calculations and make sure the directive cleanup in the
-   * `ngOnDestroy` does not rely on the `IMAGE_LOADER` logic (which in turn can rely on some other
+   * `DestroyRef.onDestroy` does not rely on the `IMAGE_LOADER` logic (which in turn can rely on some other
    * instance that might be already destroyed).
    */
   private _renderedSrc: string | null = null;
@@ -454,7 +454,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
       assertNoLoaderParamsWithoutLoader(this, this.imageLoader);
 
       ngZone.runOutsideAngular(() => {
-        this.lcpObserver!.registerImage(this.getRewrittenSrc(), this.ngSrc, this.priority);
+        this.lcpObserver!.registerImage(this.getRewrittenSrc(), this.priority);
       });
 
       if (this.priority) {
@@ -523,7 +523,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
   }
 
   /** @docs-private */
-  ngOnChanges(changes: SimpleChanges) {
+  ngOnChanges(changes: SimpleChanges<NgOptimizedImage>) {
     if (ngDevMode) {
       assertNoPostInitInputChange(this, changes, [
         'ngSrcset',
@@ -537,7 +537,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
         'disableOptimizedSrcset',
       ]);
     }
-    if (changes['ngSrc'] && !changes['ngSrc'].isFirstChange()) {
+    if (changes.ngSrc && !changes.ngSrc.isFirstChange()) {
       const oldSrc = this._renderedSrc;
       this.updateSrcAndSrcset(true);
 
@@ -554,7 +554,7 @@ export class NgOptimizedImage implements OnInit, OnChanges {
 
     if (
       ngDevMode &&
-      changes['placeholder']?.currentValue &&
+      changes.placeholder?.currentValue &&
       typeof ngServerMode !== 'undefined' &&
       !ngServerMode
     ) {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ export class LCPImageObserver implements OnDestroy {`
`92`	`92`	`return observer;`
`93`	`93`	`}`
`94`	`94`
`95`		`- registerImage(rewrittenSrc: string, originalNgSrc: string, isPriority: boolean) {`
	`95`	`+ registerImage(rewrittenSrc: string, isPriority: boolean) {`
`96`	`96`	`if (!this.observer) return;`
`97`	`97`	`const newObservedImageState: ObservedImageState = {`
`98`	`98`	`priority: isPriority,`