refactor(compiler): switch Binary.isAssignmentOperation to type guard function

fisker · thePunderWoman · commit 4fb24cadeefd · 2026-01-09T09:59:29.000-08:00
Improve `Binary.isAssignmentOperation` types
diff --git a/packages/compiler/src/expression_parser/ast.ts b/packages/compiler/src/expression_parser/ast.ts
@@ -320,7 +320,7 @@ export class Binary extends AST {
     return visitor.visitBinary(this, context);
   }
 
-  static isAssignmentOperation(op: string): boolean {
+  static isAssignmentOperation(op: string): op is AssignmentOperation {
     return (
       op === '=' ||
       op === '+=' ||

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ export class Binary extends AST {`
`320`	`320`	`return visitor.visitBinary(this, context);`
`321`	`321`	`}`
`322`	`322`
`323`		`- static isAssignmentOperation(op: string): boolean {`
	`323`	`+ static isAssignmentOperation(op: string): op is AssignmentOperation {`
`324`	`324`	`return (`
`325`	`325`	`op === '=' \|\|`
`326`	`326`	`op === '+=' \|\|`