Skip to content

Commit 1f4c380

Browse files
Keen Yee LiauAndrewKushnir
authored andcommitted
fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json (#30133)
It has a dependency on @angular/upgrade which is not part of the dependencies in package.json, so postinstall would fail. PR Close #30133
1 parent b9f0720 commit 1f4c380

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎integration/bazel-schematics/test.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function installLocalPackages() {
99
readonly pwd=$(pwd)
1010
readonly packages=(
1111
animations common compiler core forms platform-browser
12-
platform-browser-dynamic router bazel compiler-cli language-service upgrade
12+
platform-browser-dynamic router bazel compiler-cli language-service
1313
)
1414
local local_packages=()
1515
for package in "${packages[@]}"; do

‎integration/bazel/angular-metadata.tsconfig.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"node_modules/@angular/core/schematics/**",
2424
"node_modules/@angular/compiler-cli/**",
2525
"node_modules/@angular/**/testing/**",
26+
"node_modules/@angular/common/upgrade*",
2627
"node_modules/@angular/router/upgrade*"
2728
]
2829
}

‎integration/bazel/src/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"@angular/platform-browser": "packages-dist:platform-browser",
1111
"@angular/platform-browser-dynamic": "packages-dist:platform-browser-dynamic",
1212
"@angular/router": "packages-dist:router",
13-
"@angular/upgrade": "packages-dist:upgrade",
1413
"reflect-metadata": "0.1.12",
1514
"rxjs": "6.4.0",
1615
"tslib": "1.9.3",
@@ -31,4 +30,4 @@
3130
"postinstall": "ngc -p ./angular-metadata.tsconfig.json",
3231
"//": "TODO(gregmagolan): figure out how to keep dependencies here up to date with the root package.json"
3332
}
34-
}
33+
}

‎packages/bazel/src/schematics/ng-add/files/angular-metadata.tsconfig.json.template‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"node_modules/@angular/core/schematics/**",
2121
"node_modules/@angular/compiler-cli/**",
2222
"node_modules/@angular/**/testing/**",
23+
"node_modules/@angular/common/upgrade*",
2324
"node_modules/@angular/router/upgrade*"
2425
]
2526
}

0 commit comments

Comments
 (0)