Skip to content

Commit 0fc4571

Browse files
dario-piotrowiczdylhunn
authored andcommitted
fix(docs-infra): assign different aria labels to main aio navs (#45209)
assign different aria labels to the primary nav and the one used for guides and docs, so that impaired users can more easily distinguish the two PR Close #45209
1 parent 734bd8d commit 0fc4571

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

aio/src/app/app.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
<mat-sidenav-container class="sidenav-container" [class.no-animations]="disableAnimations" [class.has-floating-toc]="hasFloatingToc">
5151

5252
<mat-sidenav [ngClass]="{'collapsed': !dockSideNav}" #sidenav class="sidenav" [mode]="mode" [opened]="isOpened" (openedChange)="updateHostClasses()">
53-
<aio-nav-menu *ngIf="!showTopMenu" [nodes]="topMenuNarrowNodes" [currentNode]="currentNodes?.TopBarNarrow" [isWide]="dockSideNav"></aio-nav-menu>
54-
<aio-nav-menu [nodes]="sideNavNodes" [currentNode]="currentNodes?.SideNav" [isWide]="dockSideNav"></aio-nav-menu>
53+
<aio-nav-menu *ngIf="!showTopMenu" [nodes]="topMenuNarrowNodes" [currentNode]="currentNodes?.TopBarNarrow" [isWide]="dockSideNav" navLabel="primary"></aio-nav-menu>
54+
<aio-nav-menu [nodes]="sideNavNodes" [currentNode]="currentNodes?.SideNav" [isWide]="dockSideNav" navLabel="guides and docs"></aio-nav-menu>
5555

5656
<div class="doc-version">
5757
<aio-select (change)="onDocVersionChange($event.index)" [options]="docVersions" [selected]="currentDocVersion"></aio-select>

aio/src/app/layout/nav-menu/nav-menu.component.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,18 @@ import { CurrentNode, NavigationNode } from 'app/navigation/navigation.service';
44
@Component({
55
selector: 'aio-nav-menu',
66
template: `
7-
<aio-nav-item *ngFor="let node of filteredNodes" [node]="node" [selectedNodes]="currentNode?.nodes" [isWide]="isWide">
8-
</aio-nav-item>`
7+
<nav [attr.aria-label]="navLabel || null">
8+
<aio-nav-item *ngFor="let node of filteredNodes"
9+
[node]="node"
10+
[selectedNodes]="currentNode?.nodes"
11+
[isWide]="isWide">
12+
</aio-nav-item>
13+
</nav>`
914
})
1015
export class NavMenuComponent {
1116
@Input() currentNode: CurrentNode | undefined;
1217
@Input() isWide = false;
1318
@Input() nodes: NavigationNode[];
19+
@Input() navLabel: string;
1420
get filteredNodes() { return this.nodes ? this.nodes.filter(n => !n.hidden) : []; }
1521
}

0 commit comments

Comments
 (0)