Don't cache fragment classes across different class loaders #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhanniballake
requested changes
Oct 14, 2020
| val classLoader = CountingClassLoader() | ||
| factory.instantiate(classLoader, TestFragment::class.java.name) | ||
| factory.instantiate(classLoader, TestFragment::class.java.name) | ||
| assertEquals(1, classLoader.loadCount) |
There was a problem hiding this comment.
Please use Truth asserts (note, we already have a test dependency on Truth) over Junit asserts here and elsewhere in this file:
assertThat(classLoader.loadCount).isEqualTo(1)
Or preferably use the assertWithMessage() version that includes a more detailed message that is printed when the assert fails.
ianhanniballake
approved these changes
Oct 15, 2020
|
Thanks for putting in this PR! It'll be available in the next Fragment release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
FragmentFactory.Testing
Test: Added tests to verify the change
Issues Fixed
Fixes: 113886460