Fix regression in dynamic labels with non-string typed arguments #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in 76f9009 Reported in https://issuetracker.google.com/issues/316676794
ianhanniballake
approved these changes
Dec 19, 2023
BreezyHe
pushed a commit
to Tencent-TDS/ovCompose-multiplatform-core
that referenced
this pull request
Apr 27, 2025
Regression introduced in androidx/androidx@76f9009 Reported in https://issuetracker.google.com/issues/316676794 Test: ./gradlew navigation:navigation-ui:cC Fixes: 316676794 [AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments](https://issuetracker.google.com/issues/316676794) This is an imported pull request from androidx/androidx#636. Resolves #636 Github-Pr-Head-Sha: f455c6d1e641cc72cc1bd371b1f47b7d87ec8eff GitOrigin-RevId: 3ad8f763f17acb22678f1a87e183ef4e7dac5a9d (cherry picked from https://android-review.googlesource.com/q/commit:812fe658e564bb57b0bea0ae79946d04e2b85610) Merged-In: I94b4e28bb847632663be32b11e481d13789e8c1b Change-Id: I94b4e28bb847632663be32b11e481d13789e8c1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in 76f9009 Reported in https://issuetracker.google.com/issues/316676794
Test: ./gradlew navigation:navigation-ui:cC
Fixes: 316676794
AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments