[FragmentStrictMode] Detect calls to Fragment#setUserVisibleHint #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Navigation build is broken atm, so please ignore that 😃 |
jbw0033
approved these changes
Mar 4, 2021
ianhanniballake
approved these changes
Mar 9, 2021
|
Hey, could you rebase this? We uploaded jetifier to ignore this entire directory https://android-review.googlesource.com/c/platform/frameworks/support/+/1622522 |
simonschiller
force-pushed
the
feature/set-user-visible-hint
branch
from
16fab0f to
0e253b7
Compare
|
Rebased ✅ |
|
PS: I forgot to mention how much I really appreciate these PRs @simonschiller. Really excited to see the progression here 💯 |
|
Happy to help 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fragment#setUserVisibleHintTesting
Test: See
FragmentStrictModeTest#detectSetUserVisibleHintIssues Fixed
Fixes: 153738974