Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Update Kotlin example#2029

Merged
dodgex merged 2 commits intoandroidannotations:developfrom
WonderCsabo:updateKotlinExample
Jul 30, 2017
Merged

Update Kotlin example#2029
dodgex merged 2 commits intoandroidannotations:developfrom
WonderCsabo:updateKotlinExample

Conversation

@WonderCsabo
Copy link
Copy Markdown
Member

The manifest file is now found automatically, configuring it by hand
may cause issues.

@WonderCsabo WonderCsabo requested a review from dodgex July 26, 2017 11:54
@dodgex
Copy link
Copy Markdown
Member

dodgex commented Jul 26, 2017

Thank you, could you also update the versions in the other samples? To have them in sync.

@WonderCsabo
Copy link
Copy Markdown
Member Author

#2028 (comment)

Maybe because of this, we should not remove the kapt block from the example, because it fixes flavors with the stable Android Gradle plugin at least.

@dodgex
Copy link
Copy Markdown
Member

dodgex commented Jul 27, 2017

Maybe we should try to enhance the manifest finder to support the new(?) behaviour of kapt if they do not "fix" the issue you opened at kotlin.

I have an idea that could work, if i correctly understand the problem with the directories. I'll see if i get a hand on it this evening or tomorrow.

@WonderCsabo
Copy link
Copy Markdown
Member Author

@dodgex thanks!

@dodgex
Copy link
Copy Markdown
Member

dodgex commented Jul 27, 2017

PR is up

@WonderCsabo WonderCsabo force-pushed the updateKotlinExample branch from 45055d0 to 1e2e269 Compare July 30, 2017 09:18
The manifest file is now found automatically, configuring it by hand
may cause issues.
@WonderCsabo
Copy link
Copy Markdown
Member Author

@dodgex updated.

@dodgex
Copy link
Copy Markdown
Member

dodgex commented Jul 30, 2017

There is a travis issue due to the upgrade to 26 build tools. :/

@WonderCsabo WonderCsabo force-pushed the updateKotlinExample branch from 1e2e269 to 1cce92e Compare July 30, 2017 11:28
@WonderCsabo
Copy link
Copy Markdown
Member Author

@dodgex build fixed.

@dodgex dodgex added this to the 4.4 milestone Jul 30, 2017
@dodgex dodgex merged commit 1868ef6 into androidannotations:develop Jul 30, 2017
@WonderCsabo WonderCsabo deleted the updateKotlinExample branch February 16, 2019 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants