Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Building Gradle sample in Travis#1115

Merged
WonderCsabo merged 2 commits intoandroidannotations:developfrom
WonderCsabo:gradleSampleTravis
Aug 30, 2014
Merged

Building Gradle sample in Travis#1115
WonderCsabo merged 2 commits intoandroidannotations:developfrom
WonderCsabo:gradleSampleTravis

Conversation

@WonderCsabo
Copy link
Copy Markdown
Member

We should be sure that changes do not brake our Gradle configuration, so we are building both maven and Gradle examples in Travis.

.travis.yml Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you skip javadoc ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis builds are skipping JavaDoc by default (if the language if set to java). We should do the same here. JavaDoc is slowing the build and is polluting the logs. Or do you think it is useful?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc can prevent builds from succeeding so I think it should be tested.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it prevent?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this issue.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the javadoc goal broke i think, but you are right, since we ask our contributors to build with mvn install, Travis should do the same.

The previous version tried to resolved optional dependencies which
are no longer in Maven Central (namely android-rome-feed-reader).
The new version does not do this, so we can build without the
presence optional dependencies.
WonderCsabo added a commit that referenced this pull request Aug 30, 2014
@WonderCsabo WonderCsabo merged commit 6e089f2 into androidannotations:develop Aug 30, 2014
@WonderCsabo WonderCsabo deleted the gradleSampleTravis branch August 30, 2014 17:11
@DayS
Copy link
Copy Markdown
Contributor

DayS commented Sep 21, 2014

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants