Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

add @AfterExtras (clean)#1094

Merged
yDelouis merged 2 commits intoandroidannotations:developfrom
dodgex:AfterExtraNew
Aug 17, 2014
Merged

add @AfterExtras (clean)#1094
yDelouis merged 2 commits intoandroidannotations:developfrom
dodgex:AfterExtraNew

Conversation

@dodgex
Copy link
Copy Markdown
Member

@dodgex dodgex commented Aug 16, 2014

the clean version of this PR: #928

yDelouis added a commit that referenced this pull request Aug 17, 2014
@yDelouis yDelouis merged commit 8d7d031 into androidannotations:develop Aug 17, 2014
@yDelouis yDelouis added this to the 3.1 milestone Aug 17, 2014
@yDelouis
Copy link
Copy Markdown
Contributor

Thanks !

@WonderCsabo
Copy link
Copy Markdown
Member

@dodgex can you please update the wiki in your fork about this feature, so we can merge to our wiki?

@dodgex
Copy link
Copy Markdown
Member Author

dodgex commented Aug 18, 2014

sure. just to be sure here is what i plan to do:

am i missing something?

@dodgex dodgex deleted the AfterExtraNew branch August 18, 2014 14:54
@WonderCsabo
Copy link
Copy Markdown
Member

I think that will suffice.

@dodgex
Copy link
Copy Markdown
Member Author

dodgex commented Aug 19, 2014

i added @AfterExtras to wiki
here https://github.com/dodgex/androidannotations/wiki/Extras#executing-code-after-extras-injection
and here https://github.com/dodgex/androidannotations/wiki/AvailableAnnotations#injection

also i found this note
Note : If the parent and child classes have @AfterViews annotated methods with the same name, the generated code will be buggy. See issue #591 for more details.

i decided to extend it to contain all three @AfterXXXannotations. therefore i updated the AfterInject part and added it to the AfterViews wiki page

the new note looks like this:

Note : If the parent and child classes have @AfterViews, @AfterInject or @AfterExtras annotated methods with the same name, the generated code will be buggy. See issue #591 for more details.

@WonderCsabo
Copy link
Copy Markdown
Member

Thanks, i'll merge when i access my computer.

@dodgex
Copy link
Copy Markdown
Member Author

dodgex commented Aug 19, 2014

No problem. I'm glad i could contribute to AA! :)

I'm really happy that i now can drop my self-built snapshots ;-)

@WonderCsabo
Copy link
Copy Markdown
Member

Wiki merged, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants