Fix #50: Remove second and invalid ampersand for an l-value ref.#59
Merged
Conversation
added 2 commits
July 29, 2018 17:28
To fix #50 it is important to start ensuring that template code is valid and does not change. Hence all compiling code does define INSIGHTS_USE_TEMPLATE to enable compilation of the transformed template code.
It looks like clang does handle l-value references in the AST dump wrong. It adds a second ampersand which makes it an r-value reference. As #50 points out this second ampersand leads to invalid code. The workaround implemented here does a simple (but expensive) string search in case of an l-value ref and simply replaces the && with just &.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 95.47% 95.44% -0.04%
==========================================
Files 30 30
Lines 1946 1953 +7
==========================================
+ Hits 1858 1864 +6
- Misses 88 89 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like clang does handle l-value references in the AST dump
wrong. It adds a second ampersand which makes it an r-value reference.
As #50 points out this second ampersand leads to invalid code. The
workaround implemented here does a simple (but expensive) string search
in case of an l-value ref and simply replaces the && with just &.
To fix #50 it is important to start ensuring that template code is valid
and does not change. Hence all compiling code does define
INSIGHTS_USE_TEMPLATE to enable compilation of the transformed template
code.