feat: alias window.context to window.ampContext for clarity #40390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kishore107 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st issue #30789)
✅ Accomplishments:
Replaced:
window.context.master ➜ window.context.primary
window.context.isMaster ➜ window.context.isPrimary
Added aliases to preserve backward compatibility:
window.context.master still works via aliasing
Updated:
Core implementation
Ad vendor integrations
Tests and related documentation
Verified changes through the test suite (npm test)
🧠 Why This Change Matters
Inclusive Language: Avoids potentially problematic terms like "master/slave"
Zero Breaking Changes: All existing functionality continues to work
Developer Friendly: Provides a clear and forward-looking API
Comprehensive Update: Covers 20+ files across the AMP codebase
🧪 Testing
Ran full test suite with npm test – all tests pass
Manually verified usage in key modules