Update ReaderThemeSupportFeatures::theme_has_theme_json() with latest changes#7583
Merged
westonruter merged 3 commits intodevelopfrom Jul 11, 2023
Merged
Update ReaderThemeSupportFeatures::theme_has_theme_json() with latest changes#7583westonruter merged 3 commits intodevelopfrom
ReaderThemeSupportFeatures::theme_has_theme_json() with latest changes#7583westonruter merged 3 commits intodevelopfrom
Conversation
thelovekesh
commented
Jul 11, 2023
| * | ||
| * @todo Replace `WP_DEBUG` once an "in development mode" check is available in Core. | ||
| */ | ||
| ! ( defined( 'WP_DEBUG' ) && WP_DEBUG ) |
Collaborator
Author
There was a problem hiding this comment.
@westonruter wp_get_development_mode() is recently introduced. So should we keep WP_DEBUG instead? Or we can add this function to this file and then use it.
Member
There was a problem hiding this comment.
Good point. Yes, this should keep using WP_DEBUG. For sites with wp_get_development_mode(), they'll also have wp_theme_has_theme_json().
Contributor
|
Plugin builds for 95a0202 are ready 🛎️!
|
westonruter
reviewed
Jul 11, 2023
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Jul 11, 2023
thelovekesh
added
Bug
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7582
Checklist