Fix react unique key prop error in <SiteScanNotice /> component#7448
Merged
westonruter merged 2 commits intodevelopfrom Feb 3, 2023
Merged
Conversation
Contributor
|
Plugin builds for 19df278 are ready 🛎️!
|
westonruter
reviewed
Feb 3, 2023
westonruter
requested changes
Feb 3, 2023
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Feb 3, 2023
Member
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Thanks for proactively addressing this!
westonruter
deleted the
fix/react-key-prop-error-in-admin-site-scan-notice
branch
|
QA passed ✅ Cross-checked the issue, Fix is working as expected. Now the console error after plugin compatibility scanning is not visible. Before After fix consoleerror.mp4 |
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the react unique key prop error while rendering
<SiteScanNotice />in the plugin's admin screen which is usually triggered when someone activates a plugin.Error:
Originally discovered in #7421 (comment) while working on #7421.
Checklist