Skip to content

Add guard to avoid fatal error in case logo height/width is zero#7429

Merged
westonruter merged 6 commits intodevelopfrom
fix/fatal-error-when-logo-height-is-zero
Jan 30, 2023
Merged

Add guard to avoid fatal error in case logo height/width is zero#7429
westonruter merged 6 commits intodevelopfrom
fix/fatal-error-when-logo-height-is-zero

Conversation

@thelovekesh
Copy link
Copy Markdown
Collaborator

@thelovekesh thelovekesh commented Jan 27, 2023

Summary

Fixes #7427

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2023

Plugin builds for dea0db7 are ready 🛎️!

@thelovekesh thelovekesh self-assigned this Jan 27, 2023
@thelovekesh thelovekesh added this to the v2.4 milestone Jan 27, 2023
thelovekesh and others added 3 commits January 28, 2023 20:28
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
@westonruter westonruter merged commit d465aeb into develop Jan 30, 2023
@westonruter westonruter deleted the fix/fatal-error-when-logo-height-is-zero branch January 30, 2023 17:52
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error (division by zero) in AMP_Core_Theme_Sanitizer::add_twentytwenty_custom_logo_fix()

2 participants