Update is_frontend_url() to verify passed url path with home_url()#7330
Merged
westonruter merged 10 commits intodevelopfrom Nov 10, 2022
Merged
Update is_frontend_url() to verify passed url path with home_url()#7330westonruter merged 10 commits intodevelopfrom
is_frontend_url() to verify passed url path with home_url()#7330westonruter merged 10 commits intodevelopfrom
Conversation
Contributor
|
Plugin builds for 2c39c36 are ready 🛎️!
|
westonruter
reviewed
Nov 9, 2022
westonruter
reviewed
Nov 9, 2022
westonruter
requested changes
Nov 9, 2022
Member
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Would you also please add tests to ensure this is working as expected?
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Collaborator
Author
|
@westonruter This PR has been updated to fix all static analysis, PHPUnit, and e2e test issues. I will revert related changes from other PRs as they might get delayed in merging and failing tests cause some confusion while reviewing the PRs. |
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apart from fixing #7329 this PR also fixes the following things:
twentytwentytheme from the WP distribution.Fixes #7329
Checklist