Fix static analysis and trunk unit tests errors#7255
Merged
westonruter merged 2 commits intodevelopfrom Sep 13, 2022
Merged
Conversation
Contributor
|
Plugin builds for e39cbc7 are ready 🛎️!
|
thelovekesh
changed the title
thelovekesh
force-pushed
the
fix/static-analysis
branch
from
d0f4d5a to
e39cbc7
Compare
|
@thelovekesh when will this be released as a new update for the amp plugin? |
Member
|
@firephantomassasin We don't have the next release specifically scheduled at the moment. We'll most likely do one with fixes to compatibility with PHP 8.2 perhaps in a couple weeks. |
|
@westonruter i hope this fix will be included on the next update of the plugin. |
Member
|
@firephantomassasin Yes, it will be included for sure. It's merged into the |
|
Nice thanks!! |
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix the following issues flagged in #7254
Static analysis error
Unit tests failing on the trunk due to
.webpsupport integrated into the core.My code is tested and passes existing tests.
My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).