@westonruter I have created XPath based on the offline script id attribute, which was added in PR - GoogleChromeLabs/pwa-wp#793

One more thing to notice is that if the PWA plugin is not available in the testing environment, the test for this sanitizer will fail due to the unavailability of is_offline and is_500. I thought to add this condition in tests but it doesn't seems much feasible. What are your thoughts in this case?

if (
	! ( function_exists( 'is_offline' ) && is_offline() ) &&
	! ( function_exists( 'is_500' ) && is_500() )
) {
	return;
}

Plugin builds for 8dc21de are ready 🛎️!

• Download development build
• Download production build

Tests are failing on WP Trunk after adding decoding="async" attribute in image tags in WordPress/wordpress-develop@2702591

Tests are failing on WP Trunk after adding decoding="async" attribute in image tags in WordPress/wordpress-develop@2702591

As we discussed, to fix this lets just do the following in the various tests before we do any comparison with the $expected:

$actual = str_replace( ' decoding="async"', '', $actual );

@westonruter I was exploring this scenario and found out that something like this was also added for the loading attribute but instead of hardcoding that a conditional expression is used

Should I try something similar?

$decoding_attribute   = version_compare( get_bloginfo( 'version' ), '6.0', '>' ) ? 'decoding="async"' : '';

I believe the decoding attribute is going to be introduced in 6.1.

Should I try something similar?

That would be better, yes.

@westonruter Now the static analysis is failing. I think this can be because of the new PHPStan release.

With PHPStan version 1.7.11

With PHPStan version 1.7.12

Here's how I've been forcing to update my local PHPStan:

rm vendor/bin/phpstan
composer install --no-cache

Thanks for the info on this step 🙇🏼‍♂️