Skip to content

Update rubocop-performance requirement from ~> 1.19.0 to ~> 1.20.1 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrcuns merged 2 commits into from
Dec 26, 2023
Merged

Update rubocop-performance requirement from ~> 1.19.0 to ~> 1.20.1 #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0df0fd
Update rubocop-performance requirement from ~> 1.19.0 to ~> 1.20.1
dependabot[bot] Dec 25, 2023
37f8f3a
Fix rubocop violations
andrcuns Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ group :test do
gem "oj", "~> 3.14" if ENV["WITH_OJ_GEM"] == "true"
gem "rspec", "~> 3.12.0"
gem "rubocop", "~> 1.59.0"
gem "rubocop-performance", "~> 1.19.0"
gem "rubocop-performance", "~> 1.20.1"
gem "simplecov", "~> 0.22.0"
gem "simplecov-console", "~> 0.9.1"
end
4 changes: 2 additions & 2 deletions allure-cucumber/lib/allure_cucumber/models/metadata_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,13 @@ def issue_links
def matching_links(type)
pattern = reserved_patterns[type]
prefix = config.tms_prefix
link_pattern = config.public_send("link_#{type}_pattern")
link_pattern = config.public_send(:"link_#{type}_pattern")

tags
.grep(pattern)
.map do |tag|
tag.match(pattern) do |match|
Allure::ResultUtils.public_send("#{type}_link", prefix, match[type], link_pattern)
Allure::ResultUtils.public_send(:"#{type}_link", prefix, match[type], link_pattern)
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions allure-rspec/lib/allure_rspec/metadata_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ def behavior_labels
# @param [Symbol] type
# @return [Array<Allure::Link>]
def matching_links(type)
link_pattern = config.public_send("link_#{type}_pattern")
link_pattern = config.public_send(:"link_#{type}_pattern")
return [] unless link_pattern

metadata
.select { |key| __send__("#{type}?", key) }
.map { |key, value| Allure::ResultUtils.public_send("#{type}_link", key.to_s, value, link_pattern) }
.select { |key| __send__(:"#{type}?", key) }
.map { |key, value| Allure::ResultUtils.public_send(:"#{type}_link", key.to_s, value, link_pattern) }
end

# Label value from custom metadata
Expand Down
4 changes: 2 additions & 2 deletions allure-ruby-commons/spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ def start_test_container(name)
end

def start_fixture(name, type)
lifecycle.public_send("start_#{type}_fixture", Allure::FixtureResult.new(name: name))
lifecycle.public_send(:"start_#{type}_fixture", Allure::FixtureResult.new(name: name))
end

def add_fixture(name, type)
fixture_result = lifecycle.public_send("start_#{type}_fixture", Allure::FixtureResult.new(name: name))
fixture_result = lifecycle.public_send(:"start_#{type}_fixture", Allure::FixtureResult.new(name: name))
lifecycle.update_fixture { |fixture| fixture.status = Allure::Status::PASSED }
lifecycle.stop_fixture

Expand Down