Merged
Conversation
2 tasks
skhomuti
approved these changes
Feb 15, 2024
delatrie
added
theme:pytest
type:internal
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Lazy-fixture is incompatible with pytest 8+ (see TvoroG/pytest-lazy-fixture#65 for more details). Because of this, our tests that check compatibility between allure-pytest and lazy-fixture fail (example: https://github.com/allure-framework/allure-python/actions/runs/7892006564/job/21537573652).
This PR marks those tests as tests with expected failure if they're run under pytest 8+. If the situation doesn't change, we might remove explicit support of
lazy-fixtureentirely in the future.Additional changes
Disable pytest plugin autoload
All poe testing tasks now run pytest with plugin autoload disabled (via the
PYTEST_DISABLE_PLUGIN_AUTOLOADenv var). The outer session doesn't need any. And if an inner session requires some plugins, they are always enabled explicitly by the runner.