Skip to content

Fix duplicated fixtures after 2.11.0 release #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skhomuti merged 1 commit into from
Oct 12, 2022
Merged

Fix duplicated fixtures after 2.11.0 release #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion allure-pytest/src/listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ def pytest_runtest_call(self, item):
@pytest.hookimpl(hookwrapper=True)
def pytest_runtest_teardown(self, item):
yield
self._update_fixtures_children(item)
uuid = self._cache.get(item.nodeid)
test_result = self.allure_logger.get_test(uuid)
test_result.labels.extend([Label(name=name, value=value) for name, value in allure_labels(item)])
Expand Down
39 changes: 39 additions & 0 deletions allure-pytest/test/acceptance/fixture/fixture_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,3 +372,42 @@ def test_three(request):
)
)
)


def test_one_fixture_on_two_tests(allured_testdir):
allured_testdir.testdir.makepyfile("""
import pytest
import allure

@pytest.fixture
def fixture(request):
with allure.step(request.node.name):
pass

class TestClass:
def test_first(self, fixture):
pass

def test_second(self, fixture):
pass
""")
allured_testdir.run_with_allure()

assert_that(allured_testdir.allure_report,
has_test_case("test_first",
has_container(allured_testdir.allure_report,
has_before("fixture", has_step("test_first")),
),
not_(has_container(allured_testdir.allure_report,
has_before("fixture", has_step("test_second")),
))
),
has_test_case("test_second",
has_container(allured_testdir.allure_report,
has_before("fixture", has_step("test_second")),
),
not_(has_container(allured_testdir.allure_report,
has_before("fixture", has_step("test_first")),
))
)
)