Update namespace for Allure adapter #42
Conversation
- PHPUnit allure adapter conflicting with Codeception allure adapter
|
Thank you for fixing the issue. Looking forward for this solution to be merged! 👍 |
| <?php | ||
|
|
||
| namespace Yandex\Allure\Adapter; | ||
| namespace Yandex\Allure\PHPUnit\Adapter; |
There was a problem hiding this comment.
I would like to have Yandex\Allure\PHPUnit namespace instead as well as class named AllurePHPUnit (or PHPUnit replaced with PhpUnit in both cases if it is applicable in PHP world)
| <?php | ||
|
|
||
| namespace Yandex\Allure\Adapter; | ||
| namespace Yandex\Allure\PHPUnit\Adapter; |
There was a problem hiding this comment.
| namespace Yandex\Allure\PHPUnit\Adapter; | |
| namespace Yandex\Allure\PHPUnit; |
There was a problem hiding this comment.
@baev does it look better now? (can you see suggested code?)
There was a problem hiding this comment.
I like PhpUnit more than PHPUnit :)
There was a problem hiding this comment.
👍
PS Any thoughts on replacing to late 😄PHPUnit with PhpUnit?
There was a problem hiding this comment.
@okolesnyk will update the code shortly
@baev thank you for review
- PHPUnit allure adapter conflicting with Codeception allure adapter - Code review changes
|
Hi @baev and @okorshenko |
|
Hi @okolesnyk Thank you for quick fixes Waiting for @baev feedback |
|
@okolesnyk @okorshenko thanks! |
|
if there any other updates needed (like dependency updates) feel free to submit PR. Also it would be really appreciated if you guys review #38 I'll release the changes tomorrow |
3 participants
By adding PHPUnit to namespace we resolving issue: #41