Skip to content

Conversation

@nikser
Copy link

@nikser nikser commented Feb 12, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2018

CLA assistant check
All committers have signed the CLA.

Copy link

@okorshenko okorshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency on "phpunit/phpunit": ">=6.0.0" allow us to use any version of phpunit staring from 6.0.0 but not limited with any higher version
proposed changes "phpunit/phpunit": "6.*" allow us to use any version of phpunit in range from >=6.0.0 to <7.0.0 which looks reasonable

@baev
Copy link
Member

baev commented Dec 18, 2018

but currently in master "phpunit/phpunit": ">=7.0.0" is specified

@okorshenko
Copy link

Hi @nikser
Thank you for your contribution. Could you please resolver conflict on composer.json file

@baev
Copy link
Member

baev commented Dec 18, 2018

I guess this change is outdated after 9399629

@baev baev closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants