Dropping PHP versions before 7.1.3 and Symfony versions before 4.3 to fix #61 - #66
Merged
Conversation
|
|
remorhaz
commented
Jan 28, 2021
| stopOnFailure="false" | ||
| syntaxCheck="false" | ||
| > | ||
| <phpunit |
Contributor
Author
There was a problem hiding this comment.
Only default attribute values were removed.
remorhaz
commented
Jan 28, 2021
| public function testShouldThrowExceptionForNotImportedAnnotations(): void | ||
| { | ||
| $instance = new Fixtures\ClassWithIgnoreAnnotation(); | ||
| $this->expectException(AnnotationException::class); |
Contributor
Author
There was a problem hiding this comment.
Using annotations to intercept exceptions is deprecated in PHPUnit 8.0 and is removed in 9.0.
remorhaz
commented
Jan 28, 2021
| $step->setName(self::TEST_STEP_NAME); | ||
| $storage->put($step); | ||
| $this->assertEquals($storage->getLast()->getName(), self::TEST_STEP_NAME); | ||
| $this->assertEquals(self::TEST_STEP_NAME, $storage->getLast()->getName()); |
Contributor
Author
There was a problem hiding this comment.
Expected and actual values were in wrong order.
remorhaz
changed the title
remorhaz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a necessary evil to move forward and fix #61, I guess.
symfony/mimeto get rid of ugly hacks to make library run in modern environments. Version 4.3 requires PHP 7.1.3 or newer, and version 5 is supported, too.symfony/http-foundationanymore. No other changes made to library's code, so backward compatibility is preserved. This code can be released as 1.* without breaking any clients, Composer will take care of dependency compatibilities.phpunit.xmlstructure, so I've createdphpunit.legacy.xmlto use with older PHPUnit versions.