Skip to content

Conversation

@rPraml
Copy link
Contributor

@rPraml rPraml commented Oct 16, 2023

Context

The JavaDocDescriptionsProcessor requires the ResultsUtils.generateMethodSignatureHash
When the ResultsUtils class is loaded during AnnotationProcessing, it has initialized also the SLF4J framework, which leads to some SLF4J warnings while compiling.

Getting the logger only, when it is really needed will solve the issue (in theoretical more costs in performance, but this does not matter here)

See #962 for more info

Checklist

  • Sign Allure CLA
  • [!] Provide unit tests - this is difficult to unit test as it happens only, if there is no SLF4J implementation present - I've verified it manually and the warning is gone in my project with this change (maybe give me a hint how to test it)

@rPraml
Copy link
Contributor Author

rPraml commented Oct 19, 2023

@baev maybe you can provide feedback to this change

@baev
Copy link
Member

baev commented Dec 4, 2023

fixed via #981

@baev baev closed this Dec 4, 2023
@baev
Copy link
Member

baev commented Dec 4, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants