Skip to content

add support of scala 2.13 for allure-scalatest #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baev merged 3 commits into from
Apr 17, 2020
Merged

add support of scala 2.13 for allure-scalatest #433

baev merged 3 commits into from
Apr 17, 2020

Conversation

@viclovsky
Copy link
Contributor

@viclovsky viclovsky commented Mar 31, 2020

Context

Fixed compiling under scala 2.13, set allure-scalatest scala 2.13 as default, fixed most of 'deprecated'

Checklist

@viclovsky
Copy link
Contributor Author

viclovsky commented Apr 2, 2020

Scala 2.11 supporting is broken in master:

[Error] /Users/vicdev/IdeaProjects/allure-java/allure-scalatest/src/main/scala/io/qameta/allure/scalatest/AllureScalatest.scala:232: missing parameter type
[Error] /Users/vicdev/IdeaProjects/allure-java/allure-scalatest/src/main/scala/io/qameta/allure/scalatest/AllureScalatest.scala:233: overloaded method value updateTestCase with alternatives:
  (x$1: String,x$2: java.util.function.Consumer[io.qameta.allure.model.TestResult])Unit <and>
  (x$1: java.util.function.Consumer[io.qameta.allure.model.TestResult])Unit
 cannot be applied to (<error>, io.qameta.allure.model.TestResult => Unit)
two errors found

(scala 2.11 doesn't support SAM type)

And release versions < 2.12 isn't supported

The 2.11.11 release concludes the 2.11.x series, with no further releases planned. Please consider upgrading to 2.12!

I suggest removing 2.11 from project and supporting only two versions scala: 2.12 , 2.13

@eroshenkoam eroshenkoam requested a review from baev April 17, 2020 08:22
@baev baev merged commit b3720eb into allure-framework:master Apr 17, 2020
@atais atais mentioned this pull request Jul 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eroshenkoam eroshenkoam eroshenkoam approved these changes

@baev baev Awaiting requested review from baev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viclovsky @eroshenkoam @baev