Skip to content

Task.add annotation label for link #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baev merged 13 commits into from
May 20, 2019
Merged

Task.add annotation label for link #354

baev merged 13 commits into from
May 20, 2019

Conversation

@SergeyPirogov
Copy link
Contributor

@SergeyPirogov SergeyPirogov commented May 14, 2019 •
edited
Loading

Changes:
This PR corresponds to isssue #353 and add support for Link annotation labling.

Example:
I have test marked by Custom annotation Jira("Jira-456"), so I want to make Allure recognize it as Link and Story:

Before:

@Test
@Story("JIra-1")
@Link("Jira-1")
public void dummyTest(){}

After:

@LableAnnotation(name = "story")
@LableAnnotation(name = "link")
public @interface Jira {}

@Test
@Jira("JIra-1")
public void dummyTest(){}

Checklist

baev
baev requested changes May 14, 2019
View reviewed changes
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I so happy that you like our new @LabelAnnotation feature. But could you please explain in more details what is the use-case of such behaviour for links? I'm ok with adding such functionality but I think we should design it more carefully at this point

@SergeyPirogov
Copy link
Contributor Author

SergeyPirogov commented May 16, 2019

@baev Please provide your feedback after comments fix

baev
baev requested changes May 16, 2019
View reviewed changes
@baev baev merged commit c659614 into allure-framework:master May 20, 2019
@baev
Copy link
Member

baev commented May 20, 2019

@SergeyPirogov thanks!

@baev baev mentioned this pull request May 20, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baev baev baev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergeyPirogov @baev