Update selenide plugin related to latest selenide changes: #351
Conversation
* Split `onEvent` to `beforeEvent` and `afterEvent` blocks * Start step in `beforeEvent` block * Update and stop step in `afterEvent` block * Remove `lifecycle.getCurrentTestCase` wrap because `uuid` is not used
| .setName(event.toString()) | ||
| .setStatus(Status.PASSED)); | ||
| public void beforeEvent(final LogEvent event) { | ||
| stepUUID = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
should it really set status to PASSED? Unlike in the old implementation, this is logged before event even happened.
There was a problem hiding this comment.
Previous logic not changed. Except lifecycle.getCurrentTestCase unwrap that was unused before.
|
@eroshenkoam Houston, we need your help! |
|
Hi @baev, Could you please help us with this? |
|
yep, I reviewed the code and have it may have some problems related to concurrent test execution. I'm planning to have a deeper look at it this week |
|
I can promise you a release with this update included by the end of the week tho |
|
In order to make it fast I created separate pull request with suggested changes. Comparing to this one it has additional changes:
See #355 Thanks @rosolko for initial contribution tho 👍 |
5 participants
Changes:
onEventtobeforeEventandafterEventblocksbeforeEventblockafterEventblocklifecycle.getCurrentTestCasewrap becauseuuidis not used and all of the time step receive a new uuid in linestepUUID = UUID.randomUUID().toString();Checklist