Repository navigation
Conversation
baev
requested review from
a team and
andrcuns
and removed request for
a team
November 2, 2026 17:19
andrcuns
requested changes
Nov 4, 2026
andrcuns
left a comment
andrcuns
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the submission @antonfilichkin
My java is very rusty (almost non existent at this point 😅 ) but an agent review found a few issues, could you please check?
andrcuns
added
the
pr:improvement
antonfilichkin
force-pushed
the
feat/playwright-trace-sources-flag
branch
from
November 6, 2026 06:30
0461ca9 to
ffc9e1b
Compare
Contributor
|
@antonfilichkin Could you please take a look at failing test? |
andrcuns
self-requested a review
November 12, 2026 13:06
andrcuns
approved these changes
Nov 12, 2026
…spectJ frames from trace stacks Playwright's Tracing.StartOptions#setSources embeds a stack per action, but frame 0 is always synthetic AspectJ-weaving glue inserted by AllurePlaywrightAspect, not the real caller - making Trace Viewer's Source tab useless without this. - Add allure.playwright.trace.sources (default false) to opt into embedding sources in the trace. - Add TraceStackSourceTrimmer, which rewrites the trace.stacks entry in place: it resolves the first file-backed frame in each stack, falling back to stripping the leading run of recognizable AspectJ/Playwright weaving frames when no frame resolves. Fails open on any error, leaving the trace attached unchanged. - Declare the module's new compile-time-only dependency on Gson in module-info.java.
- Don't require PLAYWRIGHT_JAVA_SRC in the process environment: Playwright also accepts it per instance via CreateOptions.setEnv(), so the allure.playwright.trace.sources property alone now enables sources. - Rewrite only trace.stacks via the JDK zip filesystem; all other entries are copied with their original compressed payloads instead of being fully buffered in memory and re-written as STORED. - Cover per-instance configuration through AllurePlaywright.startTracing() and check that unchanged entries keep their compression.
… name Playwright 1.64 stores trace sources as src/<sha1>.java instead of resources/src@<sha1>.txt.
andrcuns
force-pushed
the
feat/playwright-trace-sources-flag
branch
from
November 12, 2026 13:06
4ce6bf3 to
b47ac9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1452
Allows attaching java sources to Playwright traces.
Allure only configures Playwright traces to include screenshots and snapshots via
Playwright allows including java sources by setting PLAYWRIGHT_JAVA_SRC and configuring tracing via
The problem:
.zipbinaryThe idea is to add configurable option to allow Allure rewrite sources and remove it's own synthetic frames
Implementation idea:
allure.playwright.trace.sources(default false) to opt into embedding sources in the trace.TraceStackSourceTrimmer, which rewrites thetrace.stacksentry in place: it resolves the first file-backed frame in each stack, falling back to stripping the leading run of recognizable AspectJ/Playwright weaving frames when no frame resolves. Fails open on any error, leaving the trace attached unchanged. With some short-circuits to disable zip/json processing - I.e. binary blobs, sources path not set.Trace examples (both with sources)
npx playwright show-trace trace-after.ziptrace-before.zip
trace-after.zip
Checklist