Skip to content

feat(allure-model): add optional attachment size #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baev merged 1 commit into from
Sep 10, 2025
Merged

feat(allure-model): add optional attachment size #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions allure-java-commons/src/test/java/io/qameta/allure/AllureLifecycleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,10 @@ void shouldAttachAsync() {
tuple(attachment2Name, "text/plain")
);

assertThat(attachments)
.extracting(io.qameta.allure.model.Attachment::getSize)
.containsOnlyNulls();

final String[] sources = attachments.stream()
.map(io.qameta.allure.model.Attachment::getSource)
.toArray(String[]::new);
Expand Down
21 changes: 21 additions & 0 deletions allure-model/src/main/java/io/qameta/allure/model/Attachment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public class Attachment implements Serializable {
private String name;
private String source;
private String type;
private Long size;

/**
* Gets name.
Expand Down Expand Up @@ -93,4 +94,24 @@ public Attachment setType(final String value) {
return this;
}

/**
* Gets size.
*
* @return the size
*/
public Long getSize() {
return size;
}

/**
* Sets size.
*
* @param value the value
* @return self for method chaining
*/
public Attachment setSize(final Long value) {
this.size = value;
return this;
}

}
Loading