Skip to content

Conversation

@baev
Copy link
Member

@baev baev commented Jul 30, 2024

Context

Checklist

@atais
Copy link

atais commented Jul 30, 2024

Great job! Thanks for fixing the missing parts!

🎆 🍾

please, dont forget to release the fixed scalatest version asap 😉

I will cancel my PR and this ultimately fixes #1104

@prokod
Copy link

prokod commented Aug 7, 2024

I have created a test similar to this PR to try and achieve the same, having <name>_2.13-<version>-<classifier> and I was not able. So currently scala cross compiling documentation stating limitation for creating scaladoc, sources for the crossed compiled artifacts still stands

@baev
Copy link
Member Author

baev commented Aug 7, 2024

@prokod, please see the final version in the main repo. You need to apply two more fixes:

  1. fix(scalatest): resolve issues with crossbuild signing #1111
  2. b40acff

After that, the release was accepted by Sonatype and successfully added to Maven Central, see https://mvnrepository.com/artifact/io.qameta.allure/allure-scalatest

@prokod
Copy link

prokod commented Aug 7, 2024

@baev with the additional code changes it makes now sense. Thx for pointing me to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants