Skip to content

HttpEntity can be null in AllureHttpClientRequest #453

Closed

Description

@baflQA

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

In https://github.com/allure-framework/allure-java/blob/master/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientRequest.java#L68 entity can be null, e.g. when a DELETE request is sent, no entity is returned by the Http client.
It causes NPE to be thrown in https://github.com/allure-framework/allure-java/blob/master/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientRequest.java#L71

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

NPE is not thrown.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Allure version 2.13.3
Test framework testng@7.0
Allure integration allure-testng@2.13.3
Generate report using allure-maven@2.13.3

Other information

Activity

  1. baflQA commented on Jun 19, 2020

    @baflQA
    ContributorAuthor

    Fixing by #453

  2. baev commented on Jun 24, 2020

    @baev
    Member

    fixed by #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions