Skip to content

fix extension initialization (fixes #123) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baev merged 2 commits into from
May 27, 2024
Merged

fix extension initialization (fixes #123) #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e015d
fix extension initialization (fixes #123)
remorhaz May 14, 2024
76e0a87
fix broken macos pipelines
remorhaz May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
os:
- ubuntu-latest
- windows-latest
Expand All @@ -29,10 +30,7 @@ jobs:
- "--prefer-lowest"
steps:
- name: Checkout
uses: actions/checkout@v3.5.0

- name: Validate composer.json and composer.lock
run: composer validate
uses: actions/checkout@v4

- name: Set up PHP ${{ matrix.php-version }}
uses: shivammathur/setup-php@v2
Expand All @@ -42,17 +40,14 @@ jobs:
coverage: xdebug
ini-values: error_reporting=E_ALL

- name: Validate composer.json and composer.lock
run: composer validate

- name: Install dependencies
run: composer update
--prefer-dist
--no-progress
${{ matrix.composer-options }}

- name: Run tests
if: ${{ matrix.php-version != '8.2' }}
run: composer test

- name: Run tests (experimental)
if: ${{ matrix.php-version == '8.2' }}
continue-on-error: true
run: composer test
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ extensions:
outputDirectory: allure-results
linkTemplates:
issue: https://example.org/issues/%s
setipHook: My\SetupHook
setupHook: My\SetupHook
```

`outputDirectory` is used to store Allure results and will be calculated
Expand Down
14 changes: 14 additions & 0 deletions src/AllureCodeception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,21 @@ final class AllureCodeception extends Extension
* @throws ConfigurationException
* phpcs:disable PSR2.Methods.MethodDeclaration.Underscore
*/
public function _initialize(): void
{
parent::_initialize();
$this->reconfigure();
}

/**
* @throws ConfigurationException
*/
public function moduleInit(): void
{
$this->reconfigure();
}

private function reconfigure(): void
{
QametaAllure::reset();
$this->testLifecycle = null;
Expand Down