Use WebSocket HTTP server to serve HTML reports #2849
+177
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does mean you have to cast and conflates caller frees vs. caller doesn't free. Done to avoid an alloc.
If you're serving real-time reports in an ad-hoc manner, it can be annoying to set up another web server to return the HTML. This makes it so that the same web server used for WebSocket updates can also serve the HTML. Many problems likely; I have not yet audited this. It is somewhat buggy too - ws_send_response likes to not return anything and thus truncates the buffer. I'm trying to find a solution to this. It also probably needs to handle the case when static resources are served in many different files.
Should avoid constant fopen, but doesn't seem to improve the truncated send buffer.
Expose get_asset_filename, load those too, and a little cleanup around serving resources.
|
Thanks for this PR! I'm seeing a Since the WS server is fundamentally built around the event loop, sending the remainder of the HTTP response will need to integrate with it properly. Given that the response is being queued in the send buffer, we'll need to adjust how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2848 for the justification, but it should simplify the case of viewing the HTML reports when GoAccess is being run on another system.
On mind for this:
Doesn't handle static resources split out to other files yet (Does so now.--external-assets)find_output_typenot allocate at all and make callers do that.