Reconcile with the new SourcePawn API#2460
Open
dvander wants to merge 4 commits into
Open
Conversation
Also remove ISourcePawnEngine and ISourcePawnEngine2 pointers since they're now redundant.
This removes a ton of tech debt and will improve Forward performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the SourcePawn library, which breaks binary compatibility for extensions (not for plugins) due to many changes to the public API.
The most significant change is that ICallable is removed. Instead, arguments are now packed into a CallArgs structure which is then passed to the VM. CallArgs is much more efficient than the old ICallable::Push API, reducing invocation overhead by about 15% on my computer.
functions.incnow uses CallArgs internally, andIForwardSyshas been augmented to use CallArgs as well.Extensions do need to be recompiled. However, the old "Push" API is retained for source-level compatibility, which is why almost no first-party extensions were changed in this PR. Well-behaving extensions will recompile with no issues.
Some extremely esoteric features were removed, so extensions using them will no longer work.