feat(catalog): enrich catalog interface with more methods#102
Open
ChaomingZhangCN wants to merge 10 commits intoalibaba:mainfrom
Open
feat(catalog): enrich catalog interface with more methods#102ChaomingZhangCN wants to merge 10 commits intoalibaba:mainfrom
ChaomingZhangCN wants to merge 10 commits intoalibaba:mainfrom
Conversation
lxy-9602
reviewed
Feb 3, 2026
lszskye
reviewed
Feb 4, 2026
Contributor
Author
lxy-9602
reviewed
Feb 5, 2026
| /// Invalidates cached table metadata. | ||
| /// | ||
| /// @param identifier Identifier of the table to invalidate. | ||
| virtual void InvalidateTable(const Identifier& identifier) {} |
Collaborator
There was a problem hiding this comment.
Does InvalidateTable need a return status?
| /// @param instant Like snapshotId or tagName | ||
| /// @return A status indicating success or failure. | ||
| virtual Status RollbackTo(const Identifier& identifier, | ||
| const std::chrono::system_clock::time_point& instant) { |
Collaborator
There was a problem hiding this comment.
instant is a time point or a snapshot id or tag name? It seems param mismatches comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Close #84
API and Format
Documentation