hotfix: 出码模块 - 解决 componentName 和 exportName 不一致时生成的 import 语句的问题#212
Merged
Clarence-pan merged 2 commits intodevelopfrom Mar 29, 2022
Merged
hotfix: 出码模块 - 解决 componentName 和 exportName 不一致时生成的 import 语句的问题#212Clarence-pan merged 2 commits intodevelopfrom
Clarence-pan merged 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决问题：对于 componentsMap 中如下这种 componentName 和 exportName 不一致的场景，期望生成的是
import Foo from "example-package"，然而之前实际生成的却是import Bar from "example-package"，现已修正：{ "package": "example-package", "version": "1.2.3", "exportName": "Bar", "componentName": "Foo", "destructuring": false }详见 icejs-import-wrong-naming.schema.json 和 icejs-import-wrong-naming.test.ts