fix: allow regex resource names with all control behaviors#3619
Open
EvanYao826 wants to merge 1 commit into
Open
fix: allow regex resource names with all control behaviors#3619EvanYao826 wants to merge 1 commit into
EvanYao826 wants to merge 1 commit into
Conversation
Previously, regex resource names were only allowed with CONTROL_BEHAVIOR_DEFAULT (fast failure). This restriction prevented users from using warm-up or queue behaviors with regex-matched resources. Now regex resource names can be used with any control behavior, as long as the rule is not in cluster mode. Fixes alibaba#3544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #3544
Previously, regex resource names were only allowed with
CONTROL_BEHAVIOR_DEFAULT(fast failure). This restriction prevented users from using warm-up or queue behaviors with regex-matched resources.Changes
In
FlowRuleUtil.checkRegexField(), removed the control behavior restriction for regex rules. Now regex resource names can be used with any control behavior (DEFAULT, WARM_UP, RATE_LIMITER, WARM_UP_RATE_LIMITER), as long as the rule is not in cluster mode.Before:
After:
Testing
Verified that flow rules with regex resource names can now be loaded with all control behaviors.