Merged
Conversation
Member
|
Hi, thanks for contributing your changes upstream. Can we organize the code in its own cepo folder under You can put a detailed README.md in that folder as well along with the configs/ We can keep the main results table under the https://github.com/codelion/optillm?tab=readme-ov-file#sota-results-on-benchmarks-with-optillm and move the rest of the details into its own README. |
This will allow users to do the following: 1. Cli where if they can pass in anything that's "cepo_<name-of-attribute>" 2. Yaml file where if they pass it in as "<name-of-attribute>" 3. If none of them have a specific attribute, we use the default setting 4. If both of them have the specific attribute, we error out
…ass for single source of truth
Added a license header
Added a link to view the file changes
Added a license header
Added a license header
984eeaa to
888bfd1
Compare
Contributor
Author
|
Thank you, @codelion! Certainly! I moved the code, config, and the CePO part of README into optillm/cepo, I only left the results for CePO vs base models in the SOTA results section. |
Member
|
Looks, good. I will merge the PR. Thank you for your contributions. I will also cut a new release of the PYPI package with these changes later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CePO as an optional method: