appengine-java8/mailgun: address checkstyle violation (GoogleCloudPlatform#2153)

shollyman · web-flow · commit 08086ded3854 · 2020-02-19T10:29:22.000-08:00
Reorder statements to address checkstyle violation.

Error from checkstyle:

[ERROR] src/main/java/com/example/appengine/mailgun/MailgunServlet.java:[60] (coding) VariableDeclarationUsageDistance: Distance between variable 'webResource' declaration and its first usage is 5, but allowed 3.  Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
diff --git a/appengine-java8/mailgun/src/main/java/com/example/appengine/mailgun/MailgunServlet.java b/appengine-java8/mailgun/src/main/java/com/example/appengine/mailgun/MailgunServlet.java
@@ -57,13 +57,13 @@ public void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOEx
   private ClientResponse sendSimpleMessage(String recipient) {
     Client client = Client.create();
     client.addFilter(new HTTPBasicAuthFilter("api", MAILGUN_API_KEY));
-    WebResource webResource =
-        client.resource("https://api.mailgun.net/v3/" + MAILGUN_DOMAIN_NAME + "/messages");
     MultivaluedMapImpl formData = new MultivaluedMapImpl();
     formData.add("from", "Mailgun User <mailgun@" + MAILGUN_DOMAIN_NAME + ">");
     formData.add("to", recipient);
     formData.add("subject", "Simple Mailgun Example");
     formData.add("text", "Plaintext content");
+    WebResource webResource =
+        client.resource("https://api.mailgun.net/v3/" + MAILGUN_DOMAIN_NAME + "/messages");
     return webResource
         .type(MediaType.APPLICATION_FORM_URLENCODED)
         .post(ClientResponse.class, formData);
