Fix #12828 (cmdline: suggestion to use --checkers-report even though it is used) (danmar#6619)

danmar · web-flow · commit 68e3d3ba31ef · 2024-07-21T14:20:30.000+02:00
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
@@ -342,7 +342,9 @@ void StdLogger::writeCheckersReport()
             what = std::to_string(activeCheckers) + "/" + std::to_string(totalCheckers);
         else
             what = "There was critical errors";
-        msg.setmsg("Active checkers: " + what + " (use --checkers-report=<filename> to see details)");
+        if (mSettings.checkersReportFilename.empty())
+            what += " (use --checkers-report=<filename> to see details)";
+        msg.setmsg("Active checkers: " + what);
 
         reportErr(msg);
     }
diff --git a/test/cli/other_test.py b/test/cli/other_test.py
@@ -1751,3 +1751,14 @@ def test_lib_lookup_multi(tmpdir):
         "looking for library '{}/cfg/gnu.cfg'".format(exepath),
         'Checking {} ...'.format(test_file)
     ]
+
+
+def test_checkers_report(tmpdir):
+    test_file = os.path.join(tmpdir, 'test.c')
+    with open(test_file, 'wt') as f:
+        f.write('x=1;')
+    checkers_report = os.path.join(tmpdir, 'r.txt')
+    exitcode, stdout, stderr, exe = cppcheck_ex(['--enable=all', '--checkers-report=' + checkers_report, test_file], remove_checkers_report=False)
+    assert exitcode == 0, stdout
+    assert 'Active checkers:' in stderr
+    assert '--checkers-report' not in stderr
