Reduce risk of port clashes

alanmcgovern · alanmcgovern · commit 7bf877645494 · 2024-08-03T17:58:45.000+01:00
Running all the tests in parallel sometimes results in port collisions,
so use a wider range of random ports.
diff --git a/src/Tests/Tests.MonoTorrent.Client/MonoTorrent.Client/MultiProtocolHttpTrackerTests.cs b/src/Tests/Tests.MonoTorrent.Client/MonoTorrent.Client/MultiProtocolHttpTrackerTests.cs
@@ -259,14 +259,15 @@ public async Task AnnounceIPv6_OnlyIPv6Active ()
                 CollectionAssert.Contains (peersFromAnnounce, peer);
         }
 
-        int preferredPort = 54399;
         ITrackerListener AddListener (AddressFamily addressFamily)
         {
             HttpTrackerListener listener = null;
 
             // Try to work around port-in-use issues in CI. Urgh. This is awful :P 
-            for (int i = 0; i < 10; i++) {
-                preferredPort++;
+            int preferredPort = -1;
+            var portGenerator = new Random ();
+            for (int i = 0; i < 100; i++) {
+                preferredPort = portGenerator.Next (10000, 50000);
 
                 if (addressFamily == AddressFamily.InterNetwork) {
                     listener = new HttpTrackerListener (new IPEndPoint (IPAddress.Loopback, preferredPort));
@@ -301,9 +302,9 @@ ITrackerListener AddListener (AddressFamily addressFamily)
 
             var uri = new Uri ($"http://localhost:{preferredPort}/announce");
             if (addressFamily == AddressFamily.InterNetwork)
-                ConnectionIPv4 = new HttpTrackerConnection (uri, Factories.Default.CreateHttpClient, AddressFamily.InterNetwork);
+                ConnectionIPv4 = new HttpTrackerConnection (uri, Factories.Default.CreateHttpClient, addressFamily);
             if (addressFamily == AddressFamily.InterNetworkV6)
-                ConnectionIPv6 = new HttpTrackerConnection (uri, Factories.Default.CreateHttpClient, AddressFamily.InterNetworkV6);
+                ConnectionIPv6 = new HttpTrackerConnection (uri, Factories.Default.CreateHttpClient, addressFamily);
 
             return listener;
         }
